Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing primer/[email protected] and updating color arguments #858

Merged
merged 13 commits into from
Oct 19, 2021

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 19, 2021

In this PR, I'm updating to primer/[email protected] which includes new color utilities, but hasn't removed the old utilities yet.

By doing this, we'll have access to the new arguments and the old arguments. I'm also adding the old arguments to our DeprecatedSystemArguments rubocop. This strategy will allow us to support both arguments while we're cleaning up deprecated arguments. Hopefully resulting in a smoother migration.

When the release hits dotcom, we'll be able to disable the lint on all violating pages and run migration scripts at our leisure.

@vercel
Copy link

vercel bot commented Oct 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/view-components/5PVMb2usQY4JidWU2KSKsHwMrzRF
✅ Preview: https://view-components-git-primer-css-17111-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview October 19, 2021 02:18 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 02:30 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 02:32 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 02:34 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 02:41 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 02:46 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 16:08 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 16:10 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 16:17 Inactive
@jonrohan jonrohan marked this pull request as ready for review October 19, 2021 16:18
@jonrohan jonrohan requested review from a team, manuelpuyol and joelhawksley October 19, 2021 16:18
@vercel vercel bot temporarily deployed to Preview October 19, 2021 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2021 16:24 Inactive
@jonrohan jonrohan merged commit 43cede7 into main Oct 19, 2021
@jonrohan jonrohan deleted the primer-css-17.11.1 branch October 19, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants