-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit docs for p5.Element #6512
Edit docs for p5.Element #6512
Conversation
These might be helpful for new users:
|
Hi Nick, I like all the changes you made to the p5.Element methods() -- they are much simpler overall. Two thoughts:
function setup() { function handleMousePressed() { |
Awesome work!
|
@dkessner @MsQCompSci very helpful feedback per usual, thank you! I'll incorporate your suggestions over the weekend. |
|
@dkessner @MsQCompSci great suggestions–thank you! @Qianqianye @limzykenneth @davepagurek if these edits look good to you, please go ahead and merge them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Addresses #6511
Changes:
I edited the inline docs for the
p5.Element
methods fromparent()
throughdragLeave()
to bring them more in line with the style guide. These docs live insrc/core/p5.Element.js
. I'll edit the docs fromsrc/dom/dom.js
in another pull request.@dkessner, @MsQCompSci, @davepagurek, @limzykenneth, @Qianqianye, @SarveshLimaye, @SoundaryaKoutharapu, @ramya202000, @BamaCharanChhandogi, @Obi-Engine10, @MarceloGoncalves, @hiddenenigma I'd love to incorporate any feedback you may have! Here's a staging version of the edits in this pull request.
PR Checklist
npm run lint
passes