Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autoSized for framebuffers #7012

Merged
merged 1 commit into from
May 6, 2024
Merged

Fix autoSized for framebuffers #7012

merged 1 commit into from
May 6, 2024

Conversation

davepagurek
Copy link
Contributor

Resolves #6998

Changes

  • Renames internal autoSized property to _autoSized so that it doesn't clash with the method autoSized()
  • Adds tests

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

@davepagurek davepagurek merged commit 87f125c into processing:main May 6, 2024
2 checks passed
@davepagurek davepagurek deleted the fix/fbo-autosized branch May 6, 2024 12:59
@yamcodes yamcodes mentioned this pull request Jun 12, 2024
Open
@saurabhpro saurabhpro mentioned this pull request Jul 12, 2024
Open
@yamcodes yamcodes mentioned this pull request Aug 22, 2024
Open
@yamcodes yamcodes mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aferriss aferriss aferriss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p5.Framebuffer.autoSized() method may be broken
2 participants
@davepagurek @aferriss