Solves issue #6891 #7165
Solves issue #6891 #7165
Conversation
src/webgl/loading.js
Outdated
| /** | ||
| * Load a 3d model from an OBJ or STL string. | ||
| * | ||
| * <a href="#/p5/loadModel">createModel()</a> should be placed inside of <a href="#/p5/preload">preload()</a>. |
There was a problem hiding this comment.
I think we don't need this sentence, since loading from a string means we don't have to asynchronously load the source code and everything happens immediately.
src/webgl/loading.js
Outdated
| * let octahedron; | ||
| * | ||
| * function preload() { | ||
| * octahedron = createModel(octahedron_model); |
There was a problem hiding this comment.
Similar to above, we can move this to setup to avoid confusion about how loading works.
src/webgl/loading.js
Outdated
| * | ||
| * function setup() { | ||
| * createCanvas(100, 100, WEBGL); | ||
| * describe('Vertically rotating 3-d octahedron.'); |
There was a problem hiding this comment.
Small update for consistency of language across our docs:
| * describe('Vertically rotating 3-d octahedron.'); | |
| * describe('Vertically rotating 3D octahedron.'); |
|
oh do we want to keep in the description in the docs of the options object, since we still allow you to pass in things like |
yeah we should , that was a mistake from my side thanks for noticing that..! |
Resolves #6891
Changes:
This is a continuation of the work initiated by @mathewpan2 in the PR #6936
I would love to have further suggestions to the work.
Thankyou!
PR Checklist
npm run lintpasses