-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: push new copa-action image on release #237
Merged
ashnamehrotra
merged 4 commits into
project-copacetic:main
from
ashnamehrotra:release-copa-action
Aug 10, 2023
Merged
feat: push new copa-action image on release #237
ashnamehrotra
merged 4 commits into
project-copacetic:main
from
ashnamehrotra:release-copa-action
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnamehrotra
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
August 8, 2023 22:44
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
release-copa-action
branch
from
August 8, 2023 22:47
022cd71
to
3b7dd94
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 34.72% 34.72%
=======================================
Files 12 12
Lines 1146 1146
=======================================
Hits 398 398
Misses 727 727
Partials 21 21 ☔ View full report in Codecov by Sentry. |
sozercan
reviewed
Aug 8, 2023
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
release-copa-action
branch
from
August 9, 2023 00:09
0bfad9f
to
a2fd65f
Compare
sozercan
reviewed
Aug 9, 2023
sozercan
reviewed
Aug 9, 2023
Signed-off-by: ashnamehrotra <[email protected]>
sozercan
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests
ashnamehrotra
added a commit
to ashnamehrotra/copacetic
that referenced
this pull request
Aug 25, 2023
Signed-off-by: ashnamehrotra <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify action releasing, instead of releasing from copa-action on every copa release, we can push the new copa-action image on each release of copa (https://github.com/orgs/project-copacetic/packages/container/package/copa-action). The copa-action releases will not need to be created often, since it will stay the same and just requires an updated copa-action image (with the new copa version) to pull from the new releases.
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Closes #<issue_ID>