Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updated trivy dependency to v0.51.4 #635

Merged
merged 5 commits into from
May 29, 2024

Conversation

ChristofferNissen
Copy link
Contributor

@ChristofferNissen ChristofferNissen commented May 25, 2024

Replace trivy v0.45.1 with v.51.4 to resolve potential vulnerability with ECS.

Convert report.Metadata.OS.Family to string as it is a string under a custom struct type masking a string

Closes #397

Signed-off-by: Christoffer Nissen <[email protected]>
Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.20%. Comparing base (2602d59) to head (bc6cb59).
Report is 72 commits behind head on main.

Current head bc6cb59 differs from pull request most recent head 4545a5d

Please upload reports for the commit 4545a5d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   32.51%   34.20%   +1.69%     
==========================================
  Files          17       18       +1     
  Lines        1621     1523      -98     
==========================================
- Hits          527      521       -6     
+ Misses       1062      969      -93     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristofferNissen ChristofferNissen changed the title c: updated trivy dependency go v0.51.4 ci: updated trivy dependency go v0.51.4 May 25, 2024
@ChristofferNissen ChristofferNissen changed the title ci: updated trivy dependency go v0.51.4 ci: updated trivy dependency to v0.51.4 May 25, 2024
@@ -1,12 +1,12 @@
module github.com/project-copacetic/copacetic

go 1.21
go 1.22.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we specify this as just 1.22?

Copy link
Contributor Author

@ChristofferNissen ChristofferNissen May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparent that does not work, go asks for running go mod tidy if omitting the .0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be ok to run go mod tidy, is it resulting in an error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just puts the value back to 1.22.0 in go.mod

Signed-off-by: Christoffer Nissen <[email protected]>
Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ashnamehrotra ashnamehrotra merged commit a194881 into project-copacetic:main May 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants