-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: updated trivy dependency to v0.51.4 #635
Conversation
Signed-off-by: Christoffer Nissen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
+ Coverage 32.51% 34.20% +1.69%
==========================================
Files 17 18 +1
Lines 1621 1523 -98
==========================================
- Hits 527 521 -6
+ Misses 1062 969 -93
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
@@ -1,12 +1,12 @@ | |||
module github.com/project-copacetic/copacetic | |||
|
|||
go 1.21 | |||
go 1.22.0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we specify this as just 1.22?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparent that does not work, go asks for running go mod tidy
if omitting the .0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be ok to run go mod tidy, is it resulting in an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just puts the value back to 1.22.0 in go.mod
Signed-off-by: Christoffer Nissen <[email protected]>
Signed-off-by: Christoffer Nissen <[email protected]>
Signed-off-by: Christoffer Nissen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Replace trivy v0.45.1 with v.51.4 to resolve potential vulnerability with ECS.
Convert
report.Metadata.OS.Family
to string as it is a string under a custom struct type masking a stringCloses #397