Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document HTTPX parameters #781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document HTTPX parameters #781

wants to merge 1 commit into from

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jan 7, 2025

No description provided.

Copy link

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1b9b042
Status: ✅  Deploy successful!
Preview URL: https://ea184888.logfire-docs.pages.dev
Branch Preview URL: https://document-httpx.logfire-docs.pages.dev

View logs

@Kludex Kludex requested a review from alexmojaki January 7, 2025 11:32
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (724fd14) to head (1b9b042).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #781   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          137       137           
  Lines        10968     10968           
  Branches       779       779           
=========================================
  Hits         10968     10968           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki
Copy link
Contributor

The page feels very verbose and repetitive. Is it because you want each section to work on its own?

Capturing bodies needs to mention something about bytes vs text.

Also I wouldn't call capture_all (or even the other params) 'fine tuning'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants