Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Report an Issue menu in DevUI #32447

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Apr 5, 2023

Things to be worked on before marking this PR as ready:

  • Parameterize the issue tracker (as it will be different when running in RHBQ)
  • List the extensions and add to the report as Additional Context
Screen-Recording-2023-04-05-at-15.24.05.mov

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Apr 5, 2023
@maxandersen
Copy link
Member

Hmm. How will this work for non community releases ?

@gastaldi
Copy link
Contributor Author

gastaldi commented Apr 5, 2023

Hmm. How will this work for non community releases ?

That's my concern in #32431 (comment), and the answer is no - at least not until we define how we'll parameterize that :)

@gastaldi gastaldi marked this pull request as draft April 5, 2023 20:03
@gastaldi
Copy link
Contributor Author

gastaldi commented Apr 5, 2023

Marking it as a draft for now

Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea a lot.

@quarkus-bot

This comment has been minimized.

bom/application/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet
Copy link
Member

gsmet commented Oct 22, 2024

@gastaldi Do you still plan to work on this one?

I think we need a way to disable it at the Platform level.

@gsmet gsmet added the triage/needs-feedback We are waiting for feedback. label Oct 22, 2024
@gastaldi
Copy link
Contributor Author

@gsmet yeah, if nobody beats me to it.

I'm planning to resume this next week (or this week if time permits)

@cescoffier
Copy link
Member

Is there anything new about this one? It could be an excellent addition to the next LTS.

@gastaldi
Copy link
Contributor Author

gastaldi commented Jan 6, 2025

It needs to be polished and disabled (or reconfigured to use JIRA) in product

@cescoffier
Copy link
Member

cescoffier commented Jan 6, 2025

I would just disable it in RHBQ or brand it: Report an upstream issue :-)

@gastaldi gastaldi force-pushed the report_devui branch 2 times, most recently from 6945262 to d1b1c85 Compare January 6, 2025 16:22
- This opens up the GitHub issue with some prefilled data
- Fixes quarkusio#32431
@gastaldi gastaldi marked this pull request as ready for review January 6, 2025 16:30
@gastaldi gastaldi requested a review from cescoffier January 6, 2025 16:30
@gastaldi
Copy link
Contributor Author

gastaldi commented Jan 6, 2025

I renamed to Report a bug in upstream Quarkus and made it always enabled

This comment has been minimized.

@cescoffier
Copy link
Member

LGTM, but let's wait for @phillip-kruger.

Copy link

quarkus-bot bot commented Jan 6, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 456ac2d.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🚧
JVM Tests - JDK 21 Build Failures Logs Raw logs 🚧
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

📦 extensions/smallrye-fault-tolerance/deployment

io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback line 27 - History - More details - Source on GitHub

java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "io.vertx.core.Context.isEventLoopContext()" because "this.vertxContext" is null
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
	at io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback(BlockingTest.java:27)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ JVM Tests - JDK 21 #

📦 extensions/smallrye-fault-tolerance/deployment

io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback line 27 - History - More details - Source on GitHub

java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "io.vertx.core.Context.isEventLoopContext()" because "this.vertxContext" is null
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
	at io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback(BlockingTest.java:27)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

⚙️ JVM Tests - JDK 17 Windows #

📦 extensions/smallrye-fault-tolerance/deployment

io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback line 27 - History - More details - Source on GitHub

java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "io.vertx.core.Context.isEventLoopContext()" because "this.vertxContext" is null
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
	at io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback(BlockingTest.java:27)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.smallrye.faulttolerance.test.asynchronous.types.mutiny.resubscription.MutinyResubscriptionTest.test line 35 - History - More details - Source on GitHub

java.lang.AssertionError: 

Expecting AtomicInteger(4) to have value:
  12
but did not.
	at io.quarkus.smallrye.faulttolerance.test.asynchronous.types.mutiny.resubscription.MutinyResubscriptionTest.test(MutinyResubscriptionTest.java:35)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cescoffier cescoffier merged commit cd1579f into quarkusio:main Jan 7, 2025
65 of 68 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 7, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 7, 2025
@gastaldi gastaldi deleted the report_devui branch January 7, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/dev-ui area/vertx kind/enhancement New feature or request release/noteworthy-feature triage/needs-feedback We are waiting for feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report bugs from the DevUI
6 participants