-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Report an Issue
menu in DevUI
#32447
Conversation
Hmm. How will this work for non community releases ? |
That's my concern in #32431 (comment), and the answer is no - at least not until we define how we'll parameterize that :) |
Marking it as a draft for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea a lot.
This comment has been minimized.
This comment has been minimized.
...s/vertx-http/runtime/src/main/java/io/quarkus/devui/runtime/ReportAnIssueJsonRPCService.java
Outdated
Show resolved
Hide resolved
...s/vertx-http/runtime/src/main/java/io/quarkus/devui/runtime/ReportAnIssueJsonRPCService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gastaldi Do you still plan to work on this one? I think we need a way to disable it at the Platform level. |
@gsmet yeah, if nobody beats me to it. I'm planning to resume this next week (or this week if time permits) |
Is there anything new about this one? It could be an excellent addition to the next LTS. |
It needs to be polished and disabled (or reconfigured to use JIRA) in product |
I would just disable it in RHBQ or brand it: Report an upstream issue :-) |
6945262
to
d1b1c85
Compare
- This opens up the GitHub issue with some prefilled data - Fixes quarkusio#32431
I renamed to |
This comment has been minimized.
This comment has been minimized.
LGTM, but let's wait for @phillip-kruger. |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | JVM Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🚧 |
✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🚧 |
✖ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🚧 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 #
📦 extensions/smallrye-fault-tolerance/deployment
✖ io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback
line 27
- History - More details - Source on GitHub
java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "io.vertx.core.Context.isEventLoopContext()" because "this.vertxContext" is null
at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
at io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback(BlockingTest.java:27)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
⚙️ JVM Tests - JDK 21 #
📦 extensions/smallrye-fault-tolerance/deployment
✖ io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback
line 27
- History - More details - Source on GitHub
java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "io.vertx.core.Context.isEventLoopContext()" because "this.vertxContext" is null
at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
at io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback(BlockingTest.java:27)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
⚙️ JVM Tests - JDK 17 Windows #
📦 extensions/smallrye-fault-tolerance/deployment
✖ io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback
line 27
- History - More details - Source on GitHub
java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "io.vertx.core.Context.isEventLoopContext()" because "this.vertxContext" is null
at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
at io.quarkus.smallrye.faulttolerance.test.asynchronous.additional.BlockingTest.threadOffloadAndFallback(BlockingTest.java:27)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
✖ io.quarkus.smallrye.faulttolerance.test.asynchronous.types.mutiny.resubscription.MutinyResubscriptionTest.test
line 35
- History - More details - Source on GitHub
java.lang.AssertionError:
Expecting AtomicInteger(4) to have value:
12
but did not.
at io.quarkus.smallrye.faulttolerance.test.asynchronous.types.mutiny.resubscription.MutinyResubscriptionTest.test(MutinyResubscriptionTest.java:35)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Things to be worked on before marking this PR as ready:
Screen-Recording-2023-04-05-at-15.24.05.mov