Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views contain semi localized elements #136

Closed
manuelvanrijn opened this issue Jul 3, 2024 · 1 comment · Fixed by #137
Closed

Views contain semi localized elements #136

manuelvanrijn opened this issue Jul 3, 2024 · 1 comment · Fixed by #137

Comments

@manuelvanrijn
Copy link
Contributor

manuelvanrijn commented Jul 3, 2024

We are running our rails app with the locale nl and I noticed that the date/time helpers are using the I18n translations, but the main part of mission control is "hard-coded" English.

This results in texts like 22 minuten ago where the 22 minuten is 🇳🇱Dutch and ago is 🇺🇸English.

SCR-20240703-lyvd

Solutions

1. Quick: Set it to English

I think the easiest way would be to set the I18n.locale to :en on a before_action (or around_action) on the ApplicationController. That way, only the Mission Control controllers will use the en locale.

2. Big: Translate all the strings!

Introduce a fully translated Rails engine :)


I'd love to create a PR for the quick one unless people think it would really benefit to introduce the localized Rails engine variant.

@manuelvanrijn manuelvanrijn changed the title Views contain some localized elements Views contain semi localized elements Jul 3, 2024
@rosa
Copy link
Member

rosa commented Jul 3, 2024

Ooh, great catch, and great report too! Dankjewel 🙏

I'd love to create a PR for the quick one unless people think it would really benefit to introduce the localized Rails engine variant.

Please do! ❤️ That'd be super helpful. I don't think it's worth translating all the strings at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants