Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce the locale to be set to English #137

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

manuelvanrijn
Copy link
Contributor

@manuelvanrijn manuelvanrijn commented Jul 3, 2024

Summary

As reported in #136, we could have a mix of translations when this default_locale is set to another language than English.

This PR resolves this by adding a around_action that set's the locale to English during the execution of the action.

I've also removed a docker volume and the version from the docker-compose.yml because the volume isn't being used, and the version is obsolete.

Fixes #136

Before

SCR-20240703-lyvd

After

image

@rosa rosa merged commit 0ddff43 into rails:main Jul 4, 2024
5 checks passed
@rosa
Copy link
Member

rosa commented Jul 4, 2024

Thank you so much again! 🙏

@n-studio
Copy link

n-studio commented Aug 8, 2024

This will cause error I18n::InvalidLocale in MissionControl::Jobs::QueuesController#index for websites that don't have the English locale available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Views contain semi localized elements
3 participants