Rework concurrency control to avoid thread locks #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch was created by Hailey Somerville in rails#52 (comment). All the credit to her. Co-authored-by: Hailey Somerville <[email protected]>
jorgemanrubia
force-pushed
the
safe-threads
branch
from
9176c87 to
a903f29
Compare
|
Sounds great @jorgemanrubia! Thanks again for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #52 (comment).
This patch was created by @haileys at #52 (comment). All the credit to her.
Since the error is a bit elusive, I'd like to test this patch for a while in our team to make sure the deadlock doesn't reproduce anymore.