Fix link in thinking-in-react.md #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rammba
requested review from
hg-pyun,
taehwanno,
simsim0709,
gnujoow,
b9words,
taggon,
MaxKim-J,
eomttt and
lumirlumir
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Size changes📦 Next.js Bundle Analysis for undefinedThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
@rammba Thank you for your hard work on React! I’m truly impressed by your passion. Yes, maintaining a translation repository can be challenging, but it’s incredibly meaningful. 😄 This PR looks good to me. However, I’ll need to merge #1114 first before merging this commit. I’ve also left a comment on the i18n issue I created! (reactjs/react.dev#7399) |
|
Thanks for the kind words! Feel free to take your time with merging major changes first. |
lumirlumir
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @lumirlumir @devwqc,
I'm really happy to see that you're maintaining this translation. As a fellow Serbian translator I must admit it's a really hard and extensive job.
I've created this PR based on the issue (reactjs/react.dev#7398) on main repo which I noticed.
Since I don't speak korean, I hope you're ok with me contributing to this repo 😉
I wish you all luck with maintaining and improving this repo 🚀