Display welcome page on install #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Kwon <[email protected]>
I think that's a bad idea and you might trigger an "installation is corrupt" warning when changing your extension after install. Generally, we are looking into a streamlined way that allows extensions to show a welcome or getting started page and my recommendation is to join us on designing that. /cc @eamodio |
|
damn that was a cool trick ;-) @jrieken is there an existing issue we could start watching about improving the 3rd party welcome page situation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
This PR implements a creative/hacky fix to display the welcome page on extension install. (ie, displays the welcome page when vscode-quarkus is installed)
The fix was to have vscode-quarkus activate on startup, show the welcome page and have vscode-quarkus manually edit the package.json file so that the startup activation event is removed.
Hi @jrieken, what do you think about this fix?
I have created a feature request for an "onExtensionInstalled" activation event to the VS Code GitHub page here: microsoft/vscode#83451