Add tests

server/core/db/boltdb_test.go

@@ -233,6 +233,18 @@ func TestLockingExistingLock(t *testing.T) {
 		Equals(t, true, acquired)
 		Equals(t, newLock, currLock)
 	}
+	// TODO: How should we handle different name?
+	/*
+		t.Log("...succeed if the new project has a different name")
+		{
+			newLock := lock
+			newLock.Project = models.NewProject(project.RepoFullName, project.Path, "different-name")
+			acquired, currLock, err := b.TryLock(newLock)
+			Ok(t, err)
+			Equals(t, true, acquired)
+			Equals(t, newLock, currLock)
+		}
+	*/
 
 	t.Log("...not succeed if the new project only has a different pullNum")
 	{

server/core/redis/redis_test.go

@@ -270,6 +270,19 @@ func TestLockingExistingLock(t *testing.T) {
 		Equals(t, newLock, currLock)
 	}
 
+	// TODO: How should we handle different name?
+	/*
+		t.Log("...succeed if the new project has a different name")
+		{
+			newLock := lock
+			newLock.Project = models.NewProject(project.RepoFullName, project.Path, "different-name")
+			acquired, currLock, err := rdb.TryLock(newLock)
+			Ok(t, err)
+			Equals(t, true, acquired)
+			Equals(t, newLock, currLock)
+		}
+	*/
+
 	t.Log("...not succeed if the new project only has a different pullNum")
 	{
 		newLock := lock

server/events/models/models.go

@@ -258,6 +258,7 @@ type Project struct {
 }
 
 func (p Project) String() string {
+	// TODO: Incorporate ProjectName?
 	return fmt.Sprintf("repofullname=%s path=%s", p.RepoFullName, p.Path)
 }
 

server/events/models/models_test.go

@@ -168,27 +168,47 @@ func TestProject_String(t *testing.T) {
 
 func TestNewProject(t *testing.T) {
 	cases := []struct {
-		path    string
-		expPath string
+		repo       string
+		path       string
+		name       string
+		expProject models.Project
 	}{
 		{
-			"/",
-			".",
+			repo: "foo/bar",
+			path: "/",
+			name: "",
+			expProject: models.Project{
+				ProjectName:  "",
+				RepoFullName: "foo/bar",
+				Path:         ".",
+			},
 		},
 		{
-			"./another/path",
-			"another/path",
+			repo: "baz/foo",
+			path: "./another/path",
+			name: "somename",
+			expProject: models.Project{
+				ProjectName:  "somename",
+				RepoFullName: "baz/foo",
+				Path:         "another/path",
+			},
 		},
 		{
-			".",
-			".",
+			repo: "baz/foo",
+			path: ".",
+			name: "somename",
+			expProject: models.Project{
+				ProjectName:  "somename",
+				RepoFullName: "baz/foo",
+				Path:         ".",
+			},
 		},
 	}
 
 	for _, c := range cases {
-		t.Run(c.path, func(t *testing.T) {
-			p := models.NewProject("repo/owner", c.path, "")
-			Equals(t, c.expPath, p.Path)
+		t.Run(fmt.Sprintf("%s_%s", c.name, c.path), func(t *testing.T) {
+			p := models.NewProject(c.repo, c.path, c.name)
+			Equals(t, c.expProject, p)
 		})
 	}
 }

server/events/pull_closed_executor_test.go

@@ -113,6 +113,17 @@ func TestCleanUpPullComments(t *testing.T) {
 			},
 			"- dir: `.` workspace: `default`",
 		},
+		{
+			"single lock, named project",
+			[]models.ProjectLock{
+				{
+					Project:   models.NewProject("owner/repo", "", "projectname"),
+					Workspace: "default",
+				},
+			},
+			// TODO: Should project name be included in output?
+			"- dir: `.` workspace: `default`",
+		},
 		{
 			"single lock, non-empty path",
 			[]models.ProjectLock{