Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding more detailed logs for policy approval #5178

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

lee2sh
Copy link
Contributor

@lee2sh lee2sh commented Dec 17, 2024

what

detailed logging when prevent_self_approval is set to true

why

tests

references

@lee2sh lee2sh requested review from a team as code owners December 17, 2024 19:37
@lee2sh lee2sh requested review from chenrui333, lukemassa and X-Guardian and removed request for a team December 17, 2024 19:37
@github-actions github-actions bot added the go Pull requests that update Go code label Dec 17, 2024
@jamengual
Copy link
Contributor

@lee2sh Please sign your commits to pass DCO.

@lee2sh lee2sh force-pushed the jsl/more_detailed_logging branch 2 times, most recently from 564482f to 6393af5 Compare December 17, 2024 20:16
@lee2sh lee2sh force-pushed the jsl/more_detailed_logging branch from 6393af5 to ef94873 Compare December 17, 2024 20:16
@jlee-nydig
Copy link

@jamengual done. thanks!

Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 17, 2024
@jamengual
Copy link
Contributor

thanks @lee2sh for the contribution

@jamengual jamengual merged commit 9e4eaa1 into runatlantis:main Dec 17, 2024
34 checks passed
@lee2sh lee2sh deleted the jsl/more_detailed_logging branch December 17, 2024 23:04
abborg pushed a commit to abborg/atlantis that referenced this pull request Dec 20, 2024
terakoya76 pushed a commit to terakoya76/atlantis that referenced this pull request Dec 31, 2024
kvanzuijlen pushed a commit to kvanzuijlen/atlantis that referenced this pull request Jan 4, 2025
lukaspj pushed a commit to lukaspj/atlantis that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants