-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding more detailed logs for policy approval #5178
Merged
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee2sh
requested review from
chenrui333,
lukemassa and
X-Guardian
and removed request for
a team
December 17, 2024 19:37
@lee2sh Please sign your commits to pass DCO. |
lee2sh
force-pushed
the
jsl/more_detailed_logging
branch
2 times, most recently
from
December 17, 2024 20:16
564482f
to
6393af5
Compare
Signed-off-by: lee2sh <[email protected]>
lee2sh
force-pushed
the
jsl/more_detailed_logging
branch
from
December 17, 2024 20:16
6393af5
to
ef94873
Compare
@jamengual done. thanks! |
jamengual
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks @lee2sh for the contribution |
1 task
abborg
pushed a commit
to abborg/atlantis
that referenced
this pull request
Dec 20, 2024
Signed-off-by: lee2sh <[email protected]>
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
Signed-off-by: lee2sh <[email protected]>
kvanzuijlen
pushed a commit
to kvanzuijlen/atlantis
that referenced
this pull request
Jan 4, 2025
Signed-off-by: lee2sh <[email protected]> Signed-off-by: kvanzuijlen <[email protected]>
lukaspj
pushed a commit
to lukaspj/atlantis
that referenced
this pull request
Jan 8, 2025
Signed-off-by: lee2sh <[email protected]> Signed-off-by: Lukas Peter Aldershaab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
detailed logging when prevent_self_approval is set to true
why
tests
references