Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pin::as_deref_mut to 1.84 relnotes #135275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Pin::as_deref_mut to 1.84 relnotes #135275

wants to merge 1 commit into from
+1 −0

Conversation

coolreader18
Copy link
Contributor

Resolves #131243 - I think this got missed in the relnotes sweep or something.

@rustbot label relnotes

@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Jan 9, 2025
@rustbot rustbot mentioned this pull request Jan 9, 2025
Closed
3 tasks
@coolreader18 coolreader18 changed the title Add Pin::as_deref_mut to relnotes Add Pin::as_deref_mut to 1.84 relnotes Jan 9, 2025
@Noratrieb Noratrieb removed the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 9, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 9, 2025

I wonder why it didn't show up, maybe due to it not having been in the 1.84.0 milestone? #129424 was definitely in 1.84.0 though so this was indeed missed. Thanks :3

r? @BoxyUwU
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 9, 2025

📌 Commit 326fedf has been approved by BoxyUwU

It is now in the queue for this repository.

@rustbot rustbot assigned BoxyUwU and unassigned Mark-Simulacrum Jan 9, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025
@traviscross traviscross mentioned this pull request Jan 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
@bors
Auto merge of rust-lang#135275 - coolreader18:pin-as_deref_mut-relnot…
1771b80 
…es, r=BoxyUwU

Add Pin::as_deref_mut to 1.84 relnotes

Resolves rust-lang#131243 - I think this got missed in the relnotes sweep or something.

`@rustbot` label relnotes
@bors
Copy link
Contributor

bors commented Jan 9, 2025

⌛ Testing commit 326fedf with merge 1771b80...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for release notes of #86918: Tracking Issue for pin_deref_mut
6 participants
@coolreader18 @rustbot @BoxyUwU @bors @Mark-Simulacrum @Noratrieb