-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle raw identifier in field #3621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think you can add a test for this somewhere into the existing ones?
Otherwise LGTM!
Hi @daxpedda, sure! I think I can add a test in |
Apologies for the delay!
That seems fine to me. |
Hi @daxpedda, it is ok! and thanks for your reply. There is a question for running tests when I follow the guide and run
my computer throws some error and shows that process panic,
Did I miss something to configure, I haven't changed the |
The error usually has nothing to do with the
No, thank you for your contribution, you are helping us here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI says formatting still has to be fixed.
Other then the nit LGTM.
Co-authored-by: daxpedda <[email protected]>
Hi @daxpedda, thanks for your review, I fixed the fmt problem, thanks ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
fix #3586, using
Ident.unraw
to handle raw identifier.