Specify "type": "module" when deploying to nodejs-module
#4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawaemon
changed the title
"type": "module" when deploying to nodejs-module
kawaemon
force-pushed
the
add-package-json-type-field
branch
4 times, most recently
from
79ffb04 to
5d97240
Compare
kawaemon
force-pushed
the
add-package-json-type-field
branch
2 times, most recently
from
64bfbaa to
0228d7c
Compare
Systemcluster
approved these changes
Oct 7, 2024
daxpedda
force-pushed
the
add-package-json-type-field
branch
from
0228d7c to
efbcb09
Compare
daxpedda
force-pushed
the
add-package-json-type-field
branch
from
efbcb09 to
83d6e77
Compare
|
i'll merge upstream later today |
All good, done already. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because this PR depends on #4091When
--target experimental-nodejs-moduleis specified, Either using.mjsextension or setting"type": "module"field onpackage.jsonis required to execute emitted javascript code using Node.js.In this PR, I used
"type": "module"approach because it makes lower impact on existing codebases since it doesn't change file name.