Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using an invalid method name as parameter when storing a template #11

Closed
editf opened this issue Mar 6, 2023 · 1 comment
Closed

Error when using an invalid method name as parameter when storing a template #11

editf opened this issue Mar 6, 2023 · 1 comment
Assignees
@mrporsev
Labels
bug Something isn't working

Comments

@editf
Copy link
Collaborator

editf commented Mar 6, 2023

Trying to store a template with an invalid method causes the following error in store_json_template:

>           variable_name, variable_value = arg.split("=")
E           ValueError: not enough values to unpack (expected 2, got 1)

httpie/cli/argtemplate.py:24: ValueError

The args passed were test_template NOT_VALID_METHOD https://catfact.ninja/fact param1=value1 param2=value2
@editf editf added the bug Something isn't working label Mar 6, 2023
editf added a commit that referenced this issue Mar 6, 2023
@editf
Add two more unit tests for store_template
9b6cd92 
This includes one test for overwriting an already existing template,
which passes, and one test for storing a template with an invalid method
parameter, which currently fails (see #11).
@editf editf mentioned this issue Mar 6, 2023
Merged
@mrporsev mrporsev self-assigned this Mar 7, 2023
mrporsev added a commit that referenced this issue Mar 7, 2023
@mrporsev
bug(template): Fix invalid argument error #11
a9df3f2
@mrporsev mrporsev mentioned this issue Mar 7, 2023
Merged
@mrporsev
Copy link
Collaborator

mrporsev commented Mar 7, 2023

done

@mrporsev mrporsev closed this as completed Mar 7, 2023
mrporsev added a commit that referenced this issue Mar 7, 2023
@mrporsev
Merge pull request #17 from sanredz/mrporsev/work-on-editt
324a6d7 
bug(template): Fix invalid argument error #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrporsev mrporsev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrporsev @editf