Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #2308

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Update dependencies #2308

merged 3 commits into from
Sep 19, 2019

Conversation

Mygod
Copy link
Contributor

@Mygod Mygod commented Sep 17, 2019

Fixes #2306.

Warning: While errors are unlikely, this PR is untested because I do not have time.

@vmadalin For the rest of your changes, there are good reasons (to me) to ignore the warnings and not suppress them at the same time.

@Mygod Mygod requested a review from madeye September 17, 2019 03:43
@vmadalin
Copy link

Thank you for make the patch of some change from my PR and added new one. I understand your point of view to ignore the rest of warnings for the moment, and don't tacking them into count. But remember some of them are more or less important like the following, and they should not be forgotten.

Internationalization:Bidirectional Text
--
2 | warning RtlHardcoded: Using left/right instead of start/end attributes
1 | warning RtlEnabled: Using RTL attributes without enabling RTL support

This break the layout for arabic languages.

madeye
madeye approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@madeye madeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mygod Mygod merged commit 11c09ef into shadowsocks:master Sep 19, 2019
@Mygod Mygod deleted the update branch September 19, 2019 00:54
bannedbook pushed a commit to bannedbook/SpeedUp.VPN that referenced this pull request Dec 25, 2019
@Mygod
Update dependencies and refine style (shadowsocks#2308)
8a5e37b 
* Update dependencies

* Fix styling issues

* Some more fixes

Fixes shadowsocks#2306.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmadalin vmadalin vmadalin approved these changes

@madeye madeye madeye approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mygod @vmadalin @madeye