-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lancedb Integration #1444
Lancedb Integration #1444
Conversation
@okhat Please approve the workflow. If any changes are required let me know. |
Hey @PrashantDixit0, happy to help with this! 👋
|
Sure I'll fix these conflits and linting asap |
@CShorten While running
|
Thanks @PrashantDixit0, maybe for now let's revert the commit of running the linter on all the files. I noticed this when I took a look this morning as well. I'm surprised this changed as many files as it did though, for me it was about ~8 this morning and I was able to manually inspect that it was mostly unused variables, etc. as mentioned in my original comment. @isaacbmiller @insop can you please advise us on this? |
With @CShorten 's nudge, I went over the change. |
4127fdd
to
98f9dbb
Compare
I'll relock poetry file |
@isaacbmiller @CShorten Done 👍, Now conflicts are resolved |
Thank you so much @isaacbmiller @insop @PrashantDixit0! 🔥 🚀 |
This PR adds LanceDB as a retriever to handle large datasets.