fix: No longer crashing notebooks & spamming console w image urls #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thanks a lot @glesperance ! |
|
@glesperance one test failed, mind checking and adjusting the code or the test? |
|
@okhat fixed the broken test & added an additional one for dspy.Image handling |
|
@isaacbmiller can we merge this now? or does it conflict with the PR on Images in types? |
|
Just saw that we went to main. Thanks everyone! |
isaacbmiller
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing DSPy Examples containing images creates problems because they flood the console / notebook outputs with massive base64-encoded strings.
Base64-encoded images can be thousands of characters long, making it nearly impossible to read other important output or debug information.