Caching fix - only try/cache key creation #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dbczumar <[email protected]>
Signed-off-by: dbczumar <[email protected]>
dbczumar
commented
Dec 10, 2024
| @@ -150,3 +150,16 @@ def test_lm_calls_with_callables_are_cached_as_expected(): | |||
| lm_without_callable("Query") | |||
|
|
|||
| assert mock_completion.call_count == 2 | |||
|
|
|||
|
|
|||
| def test_lms_called_expected_number_of_times_for_cache_key_generation_failures(): | |||
There was a problem hiding this comment.
Fails on main:
FAILED test_caching.py::test_lms_called_expected_number_of_times_for_cache_key_generation_failures - AssertionError: assert 2 == 1
Signed-off-by: dbczumar <[email protected]>
Signed-off-by: dbczumar <[email protected]>
isaacbmiller
pushed a commit
that referenced
this pull request
Dec 11, 2024
* fix Signed-off-by: dbczumar <[email protected]> * Test Signed-off-by: dbczumar <[email protected]> * fix Signed-off-by: dbczumar <[email protected]> * fix Signed-off-by: dbczumar <[email protected]> --------- Signed-off-by: dbczumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching fix - only try/cache key creation