Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs_uri_column_name to DatabricksRM #1929

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

chenmoneygithub
Copy link
Collaborator

@chenmoneygithub chenmoneygithub commented Dec 12, 2024

As requested by Mosaic agent framework, we need to give users the flexibility to choose the column name for doc uri in order for agent framework to successfully render the trace. Previously we made a wrong assumption on the doc_uri format.

We will also do the following in the future:

  • Remove the use_with_databricks_agent_framework flag and the logic branch.
  • Move the Document conversion logic into MLflow.
  • Delete the set_retriever_schema call.

This PR keeps it small to only unblock users, will have followup PRs for the other items.

@okhat okhat merged commit 469d037 into stanfordnlp:main Dec 13, 2024
4 checks passed
@chenmoneygithub chenmoneygithub deleted the more-fix-databricksrm branch December 27, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants