-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support of dynamically sized Eigen types #1541
Conversation
Thanks for this! I can tweak the code a bit to handle buffer bounds safety. Could you add some unit tests to the The simple solution for writing safely is |
@WanZhiQiu-ac, I guess I just collided with you, but I merged our changes. |
@WanZhiQiu-ac, I'll add some more unit tests. I limited the specialization for matrices with both rows and columns being dynamic, because Glaze already supported dynamic vectors in a way that didn't need to serialize the extents. |
@WanZhiQiu-ac, I've added more tests, but some are breaking, so I need to work through them. |
@WanZhiQiu-ac I'm going to merge this in, but make another pull request if you want to handle layout checking or transposing. But, this should now serialize/deserialize dynamic matrices. |
I use
b[ix++] = '[';
because I saw something likeso this might be safe. Not so sure.
A quick test: