Use 'pycodestyle' instead of 'pep8' #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool has been renamed two years ago -- PyCQA/pycodestyle#466
So pylint can load extensions like ped and check the code.
PEP8 has changed and it now requires line breaks before a binary operator instead after: https://hg.python.org/peps/rev/3857909d7956 Unfortunately older versions of pep8 still report it as warning (W503) and we don't have a simple way how to ignore different warnings based on pep8 version.
New version of pycodestyle added some new warnings/errors. E305 expected 2 blank lines after class or function definition E741 ambiguous variable name E722 do not use bare 'except'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pep8 has been renamed to pycodestyle PyCQA/pycodestyle#466 but the python-pep8 package in Fedora has never been deprecated, so we are still using the two years old 1.6 version. Fortunately newest python-codestyle is available for both Fedora and RHEL/CentOS 7 so we can switch to it.
This also containts fixes for some new errors/warnings discovered by the newest pycodestyle.