Add Notification Banner Callback #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riquelme-stripe
commented
Jul 15, 2024
app/(dashboard)/home/page.tsx
Outdated
| actionRequired: number; | ||
| }) => { | ||
| if (response && response.total > 0) { | ||
| setTotal(response.total); |
There was a problem hiding this comment.
Although we set the total value here, it's not actually used currently. I'm happy to remove this unless we want to keep it as an example.
There was a problem hiding this comment.
let's remove if we're not using!
Screen.Recording.2024-07-15.at.2.12.16.PM.mov |
Signed-off-by: riquelme-stripe <[email protected]>
Signed-off-by: riquelme-stripe <[email protected]>
eliang-stripe
approved these changes
Jul 15, 2024
app/(dashboard)/home/page.tsx
Outdated
| actionRequired: number; | ||
| }) => { | ||
| if (response && response.total > 0) { | ||
| setTotal(response.total); |
There was a problem hiding this comment.
let's remove if we're not using!
app/(dashboard)/home/page.tsx
Outdated
| {/* </Container> */} | ||
| </div> | ||
|
|
||
| {/* // end */} |
app/(dashboard)/home/page.tsx
Outdated
| onNotificationsChange={renderConditionallyCallback} | ||
| /> | ||
| </EmbeddedComponentContainer> | ||
| {/* </Container> */} |
app/(dashboard)/settings/page.tsx
Outdated
| onNotificationsChange={renderConditionallyCallback} | ||
| /> | ||
| </EmbeddedComponentContainer> | ||
| {/* </Container> */} |
…pe/stripe-connect-furever-demo into riquelme-notificationBannerCallback
jojo-stripe
reviewed
Jul 16, 2024
| @@ -20,17 +22,35 @@ export default function Dashboard() { | |||
|
|
|||
| const BREAKPOINT = 1190; | |||
|
|
|||
| const [showBanner, setShowBanner] = React.useState(false); | |||
There was a problem hiding this comment.
I see you've already merged this so it's no biggie, but in the future we can probably abstract all of this into its own component to avoid code duplication and easily use the notification banner if we want to add it to other places
There was a problem hiding this comment.
I can open a new PR with this refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the Notification Banner to its own section and conditionally renders if notifications are present.
Screen.Recording.2024-07-15.at.12.59.42.PM.mov