Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the new CapitalFinancingPromotion component #209

Merged

Conversation

chaitali-stripe
Copy link
Contributor

Switch the old CapitalOverview embedded component to the new CapitalFinancingPromotion embedded component. This new embedded component will display details of a financing offer for the account if there is one.

Switch the old CapitalOverview embedded component to the new CapitalFinancingPromotion embedded component. This new embedded component will display details of a financing offer for the account if there is one.
Copy link
Contributor

@streeter-stripe streeter-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my suggestion, and the formatting issue, this looks great!

Copy link

@jade-stripe jade-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @streeter-stripe 's suggestion, but other than that, looks great!

Fix lint errors and add switch statement to render the Capital offer promotion.
Updating formatting with Prettier
Copy link
Contributor

@streeter-stripe streeter-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@chaitali-stripe chaitali-stripe merged commit 0e96d6d into master Jan 7, 2025
2 checks passed
@chaitali-stripe chaitali-stripe deleted the chaitali-stripe-connect-furever-demo-capital-ec branch January 7, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants