Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Stage 3 tracking #19

Closed
8 tasks done
bakkot opened this issue May 22, 2018 · 13 comments
Closed
8 tasks done

Stage 3 tracking #19

bakkot opened this issue May 22, 2018 · 13 comments

Comments

@bakkot
Copy link
Collaborator

bakkot commented May 22, 2018

This proposal achieved stage 2 at the May 2018 meeting. This is a tracking issue for getting stage 3.

@bathos
Copy link
Collaborator

bathos commented Jun 11, 2018

@bakkot Out of curiosity, is it expected that stage 3 will be discussed in July?

@bakkot
Copy link
Collaborator Author

bakkot commented Jun 11, 2018

@bathos Not sure yet; it depends on how much time various committee members have. I'll update when I know.

@mbrowne

This comment has been minimized.

@ljharb

This comment has been minimized.

@mattijs
Copy link
Member

mattijs commented Jun 29, 2018

Reviewed the spec text, LGTM

@bmeck
Copy link
Member

bmeck commented Jun 29, 2018

Spec text looks good.

@michaelficarra
Copy link
Member

I don't like the fact that 4.d. has a single sub-step (i). This can be removed. Otherwise LGTM.

@ljharb
Copy link
Member

ljharb commented Jul 11, 2018

Hmm, it seems a little long, and hiding the fact that it returns early, if it’s inlined. Why don’t you like the single substep?

@bterlson
Copy link
Member

@ljharb if X, return has precedence and is used elsewhere in this algorithm so I tend to agree with @michaelficarra that it'd be preferable stylistically.

The only other comment I'd make is that the note at the end could probably just be prose at the top ala how e.g. parseFloat contains a normative description before the algorithm steps.

@bterlson
Copy link
Member

Otherwise LGTM!

@ljharb
Copy link
Member

ljharb commented Jul 11, 2018

Sounds good, I'll make those changes now, and check off your boxes afterwards.

@bakkot
Copy link
Collaborator Author

bakkot commented Jul 11, 2018

@bathos, update as promised: looks like we're going to try for stage 3 at the July meeting.

@ljharb ljharb closed this as completed in d25e878 Jul 24, 2018
@ljharb ljharb mentioned this issue Jul 24, 2018
14 tasks
@bakkot
Copy link
Collaborator Author

bakkot commented Jul 24, 2018

This achieved stage 3 at the July 2018 meeting!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants