-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support accessing PostgreSQL on unix domain sockets #4456
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The documentation is potentially confusing: "If this is provided, the database host, port need not be provided.", but above it says Looking at the change, none of the Apart from that, assuming it works, looks good to me. |
I've adjusted the docs to hopefully make more sense. Can confirm that I'm running with this commit - it does work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ty for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the linting issues. Please follow https://docs.teslamate.org/docs/development#code-formatting
Fixes #4249.
A common way to deploy Postgres is to not have a port. This can simplify user management as if all users log in using Unix Domain Sockets, the OS handles authentication.
This MR allows the user to optionally provide the directory their socket is stored in.