initDSProfile: correct std::vector usage #4124
Conversation
src/opencl/openclwrapper.cpp
Outdated
| profile->devices.reserve(profile->numDevices); | ||
| memset(&profile->devices[0], 0, profile->numDevices * sizeof(ds_device)); | ||
| profile->devices.resize(profile->numDevices); | ||
| memset(profile->devices.data(), 0, profile->numDevices * sizeof(ds_device)); |
There was a problem hiding this comment.
Is the memset still needed? The resize method should already fill all new elements with zero.
There was a problem hiding this comment.
You are right, it initializes it with default. My intent was to minimize changes and follow safe programming (e.g. who said that it wouldn't have any values inserted before). So may adress it here (in that PR) or suggest a small refactoring of that function (as for me it has a mix of c/c++ and unndeded complexity) done by me in next PR.
There was a problem hiding this comment.
Do you plan to use Tesseract with OpenCL or are you already using it? In my tests (done some years ago) it did not work good enough to justify more efforts to improve that code.
There was a problem hiding this comment.
Instead of modifying line 194 I suggest to remove it in the PR here. Additional changes can be done in another PR later.
There was a problem hiding this comment.
Do you plan to use Tesseract with OpenCL or are you already using it? In my tests (done some years ago) it did not work good enough to justify more efforts to improve that code.
Doing some PoCs to see if I can use it.
src/opencl/openclwrapper.cpp
Outdated
| profile->devices.resize(profile->numDevices); | ||
| memset(profile->devices.data(), 0, profile->numDevices * sizeof(ds_device)); |
There was a problem hiding this comment.
| profile->devices.resize(profile->numDevices); | |
| memset(profile->devices.data(), 0, profile->numDevices * sizeof(ds_device)); | |
| profile->devices.resize(profile->numDevices); |
Inside initDSProfile use std::vector::resize instead of std::vector::reserve, due to later usage it by index that triggers debug cheks (reserver does not change size) under MSVC.