-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make regular usage of CMAKE_INSTALL_LIBDIR and GNUInstallDirs #4272
Conversation
What is a benefit of this? Especially for non GNU installation like Windows? |
This doesn't affect a windows installation, as it only modifies unix installation code. |
But what it the benefit of this PR? What kind of problem are you solving? |
Avoiding the need to manually define |
Maybe change the default to lib64? |
Linux installations for i686, older Raspberry PI distributions, other 32 bit embedded systems don't have |
Not all distros use |
I checked openSUSE and it use booth (lib & lib64) |
I make basic build&install test on Windows and openSUSE and I do not see problem with this PR.
|
Use CMake's logic to define
CMAKE_INSTALL_LIBDIR
rather than relying on a user override, and make use of the additional abstraction that theGNUInstallDirs
module allows.