Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make regular usage of CMAKE_INSTALL_LIBDIR and GNUInstallDirs #4272

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Make regular usage of CMAKE_INSTALL_LIBDIR and GNUInstallDirs #4272

merged 1 commit into from
Jun 21, 2024

Conversation

Zopolis4
Copy link
Contributor

Use CMake's logic to define CMAKE_INSTALL_LIBDIR rather than relying on a user override, and make use of the additional abstraction that the GNUInstallDirs module allows.

@zdenop
Copy link
Contributor

zdenop commented Jun 21, 2024

What is a benefit of this? Especially for non GNU installation like Windows?

@Zopolis4
Copy link
Contributor Author

This doesn't affect a windows installation, as it only modifies unix installation code.

@zdenop
Copy link
Contributor

zdenop commented Jun 21, 2024

But what it the benefit of this PR? What kind of problem are you solving?

@Zopolis4
Copy link
Contributor Author

Avoiding the need to manually define CMAKE_INSTALL_LIBDIR as lib64 on systems where this is the default value.

@egorpugin
Copy link
Contributor

Maybe change the default to lib64?
What are systems with lib today?

@stweil
Copy link
Member

stweil commented Jun 21, 2024

Maybe change the default to lib64?
What are systems with lib today?

Linux installations for i686, older Raspberry PI distributions, other 32 bit embedded systems don't have lib64 as far as I know.

@Zopolis4
Copy link
Contributor Author

Not all distros use lib64-- using GNUInstallDirs ensures that tesseract will match whatever is the default for that platform.

@zdenop
Copy link
Contributor

zdenop commented Jun 21, 2024

I checked openSUSE and it use booth (lib & lib64)

@zdenop
Copy link
Contributor

zdenop commented Jun 21, 2024

I make basic build&install test on Windows and openSUSE and I do not see problem with this PR.

  • leptonica using GNUInstallDirs already, so I do not expect problems.

@stweil stweil merged commit 2991d36 into tesseract-ocr:main Jun 21, 2024
1 check passed
@Zopolis4 Zopolis4 deleted the sandefault branch June 21, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants