Using dropRight instead of tail for shortening BytesSpec array #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
added a commit
that referenced
this pull request
Feb 22, 2016
Using dropRight instead of tail for shortening BytesSpec array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A truncated array is only guaranteed to compare as less if the truncation happens at the end. Also we should be able to compare an empty Array so I'm not excluding the case where length == 1.
I've verified this by testing with a "\0" prefix on the random string (which makes the original code fail consistently).
Also testing empty arrays here.
Recreates #504
Fixes #503