Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] Fix style details and correctly pass version info #74606

Open
wants to merge 6 commits into
base: 01-08-_devoverlay_add_next.js_version_staleness_indicator
Choose a base branch
from

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 7, 2025

This PR fixed the followings:

  • versionInfo was omitted in the Errors component.
  • The border radius of the Error type label chip is 6px in design but was 8px in dev.
  • Removed unnecessary margins and paddings that took unexpected space.

Light

CleanShot 2025-01-08 at 03 20 53

Dark

CleanShot 2025-01-08 at 03 21 00

@devjiwonchoi devjiwonchoi changed the title [DevOverlay] Polish style details for error type label and message [DevOverlay] Fix style details and correctly pass version info Jan 7, 2025
@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 7, 2025 18:24
@ijjk
Copy link
Member

ijjk commented Jan 7, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
buildDuration 28.9s 24.3s N/A
buildDurationCached 23.8s 20.4s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +110 kB
nextStartRea..uration (ms) 875ms 811ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 233 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 520 B N/A
Overall change 538 B 538 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
middleware-b..fest.js gzip 667 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 364 kB 365 kB ⚠️ +669 B
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 353 kB 353 kB ⚠️ +626 B
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.45 MB 2.45 MB ⚠️ +1.29 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message Change
0.pack gzip 2.09 MB 2.09 MB ⚠️ +3.76 kB
index.pack gzip 75 kB 74 kB N/A
Overall change 2.09 MB 2.09 MB ⚠️ +3.76 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: ea87b89

@ijjk
Copy link
Member

ijjk commented Jan 7, 2025

Tests Passed

@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message branch from dd8d83c to 1d68901 Compare January 8, 2025 10:49
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from 8c6f05a to 516f2a5 Compare January 8, 2025 14:00
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message branch from daa0478 to fe5331c Compare January 8, 2025 14:00
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from 516f2a5 to a1040b2 Compare January 9, 2025 04:45
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message branch from fe5331c to 79d144e Compare January 9, 2025 04:45
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from a1040b2 to 7827401 Compare January 9, 2025 07:24
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message branch from 79d144e to ea87b89 Compare January 9, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants