Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use npm instead of yarn #30

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

quant-eagle
Copy link
Contributor

Summary

This PR transitions the project from Yarn to npm for package management. This change aligns with the decision by the VS Code maintainers to move away from Yarn. Npm has caught up in features, notably with automatic peer dependency installation (npm 7+), and Yarn v1 is no longer actively maintained.

Changes

  • Replaced Yarn with npm across the project.
  • Removed yarn.lock and generated a new package-lock.json.
  • Updated build and CI scripts.

Why is this needed?

Yarn v1 has become outdated, while npm now provides similar functionality and better long-term support. This transition aligns with the upstream VS Code repository to ease integration and reduce maintenance efforts.

Checklist

  • Updated all references to Yarn in the codebase.
  • Removed yarn.lock and generated package-lock.json.
  • Tested the project with npm to ensure builds are functioning correctly.

Testing

Ensure that all contributors are using npm, and that the project builds and tests run successfully with the new package manager.

Additional Information

Switching to npm helps keep this fork aligned with VS Code upstream, ensuring smoother dependency management and long-term stability. Should you face any issues, please report them for resolution.

@mathewpareles mathewpareles merged commit 7f799a5 into voideditor:main Sep 19, 2024
@quant-eagle quant-eagle deleted the feat/use_npm branch September 19, 2024 20:11
@andrewpareles
Copy link
Contributor

Any idea how to do nonlocal imports with npm @deepak1556 or @quant-eagle? If you could help me do a PR where void.contribution.ts simply imports 'openai' and prints it out, that'd be a ton of help right now.

I'm getting in touch because it looks like migrating from yarn to npm makes imports a lot more difficult. I spent a lot of time trying to import 'openai' in void.contribution.ts, and am considering reverting to yarn because I think it'd be easier. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants