Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using document.all #173

Merged
merged 1 commit into from
Nov 13, 2016

Conversation

pifantastic
Copy link
Contributor

document.all returns an HTMLAllCollection which has some, uhm, special, behavior. This is causing errors when es6-shim is present, which in some cases overwrites the native Array.prototype.find with its own implementation.

This is an attempt to prevent vue-devtools from throwing an error in Chrome when es6-shim is present.

See: paulmillr/es6-shim#428

@ljharb
Copy link

ljharb commented Nov 13, 2016

It's also worth noting that document.all has been heavily deprecated for almost a decade now, and should never be used, regardless of library bugs with it.

@yyx990803 yyx990803 merged commit 34f9c41 into vuejs:master Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants