Fetching block details from database #58
Conversation
|
Someone is attempting to deploy a commit to the Walnut Team on Vercel. A member of the Team first needs to authorize it. |
|
@saimeunt Do have a look at this! |
There was a problem hiding this comment.
@PoulavBhowmick03 nice work, please make the requested changes and we'll merge this ASAP.
src/components/lib/fetch-data.ts
Outdated
There was a problem hiding this comment.
This file is a leftover and is no longer needed, please delete it.
prisma/schema.prisma
Outdated
There was a problem hiding this comment.
Please only commit the renaming of POSTGRES_URL to DATABASE_URL but keep the default option to use sqlite.
| import { prisma } from "@/lib/prisma"; | ||
|
|
||
| type FetchBlockDetailsReturnType = { | ||
| block: Block | null; |
There was a problem hiding this comment.
Since these functions returns only a Block or null, there's no need for this helper type, just specify their return type as Block | null directly.
| const fetchBlockDetailsFromDatabase = async ( | ||
| number: bigint, | ||
| ): Promise<FetchBlockDetailsReturnType> => { | ||
| console.log(`Attempting to fetch block ${number} from database`); |
There was a problem hiding this comment.
Remove all the console.logs, we don't want them outside of testing purpose.
| ): Promise<FetchBlockDetailsReturnType> => { | ||
| console.log(`Attempting to fetch block ${number} from database`); | ||
| const block = await prisma.block.findUnique({ | ||
| where: { number: BigInt(number) }, |
There was a problem hiding this comment.
number is already a bigint, there's no need to cast it to BigInt.
| console.log(`Fetching block ${number} from JSON-RPC`); | ||
| const block = await l2PublicClient.getBlock({ blockNumber: number }); | ||
|
|
||
| if (!block) { |
There was a problem hiding this comment.
The next few lines can be simplified by return block ? fromViemBlock(block) : null;
|
@saimeunt , thank you! made the changes, do have a look |
|
@PoulavBhowmick03 there's a final change to be made here: Remove the curly braces because we're no longer returning an enclosing object. |
|
@saimeunt done |
Related Issues
Closes #53
Changes
fetchBlockDetailsincomponents/pages/block/fetch-block-details.tscomponents/pages/block/index.tsxto use the newfetchBlockDetailsfunctionImplementation Details
fetchBlockDetailsfunction is data source agnosticfetchBlockDetailsFromJsonRpc: fetches data from JSON-RPC (existing behavior)fetchBlockDetailsFromDatabase: fetches data from the database (new implementation)DATABASE_URLenvironment variableValidation
Additional Notes