Unregister player (in classroom module) interval and timeout on refresh #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works like player events unregister on refresh, while maintaining the ability to clear them manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with the classroom module, events registered by an user are unregistered on reload, which is a really, really, really useful feature (as you don't need to do it yourself or refresh() if you forgot to do it yourself). Unfortunately, this doesn't apply for interval and timeout, resulting in many many refresh() to remove those old interval.
This let the classroom module unregister player-defined interval and timeout, in the same way events handlers are unregistered.