Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNCalendarEvents.m #253

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Update RNCalendarEvents.m #253

merged 3 commits into from
Oct 1, 2019

Conversation

eladgel
Copy link

@eladgel eladgel commented Jun 12, 2019

Dont add structured location if no title and no radius, the app crashes otherwise

Dont add structured location if no title and no radius
@mtimmens
Copy link

mtimmens commented Aug 7, 2019

Thanks, this resolved #258 for us.

@saghul
Copy link
Collaborator

saghul commented Sep 3, 2019

@wmcmahan Any chance you could merge this one?

@robertherber
Copy link

Please merge this, spent A LOT of time tracking down this bug. Thanks!

@eladgel
Copy link
Author

eladgel commented Sep 22, 2019

Also added a check to make sure a calendar event has a color otherwise the app crashes

@wmcmahan wmcmahan merged commit 4cb815b into wmcmahan:master Oct 1, 2019
@prasanthsd
Copy link

Can we please have this merged?

@alindao-charles
Copy link

Any updates on this?

@MoOx
Copy link
Collaborator

MoOx commented Jun 11, 2020

This has been merged. Just not released yet as I didn't have the time to test the integrity of the recent merged work.
If you want to help, you can try to use master branch & check if everything run correctly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants