Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Update fish audio #2555

Merged
merged 5 commits into from
Nov 15, 2024
Merged

ENH: Update fish audio #2555

merged 5 commits into from
Nov 15, 2024

Conversation

codingl2k1
Copy link
Contributor

@codingl2k1 codingl2k1 commented Nov 14, 2024 •
edited by qinxuye
Loading

Fixes #2526

@XprobeBot XprobeBot added the enhancement New feature or request label Nov 14, 2024
@XprobeBot XprobeBot added this to the v0.16 milestone Nov 14, 2024
@qinxuye qinxuye marked this pull request as ready for review November 15, 2024 04:57
qinxuye
qinxuye approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye marked this pull request as draft November 15, 2024 05:39
@qinxuye
Copy link
Contributor

qinxuye commented Nov 15, 2024

CI cannot pass. Can you check the error in GPU CI?

@qinxuye qinxuye marked this pull request as ready for review November 15, 2024 09:33
@qinxuye qinxuye merged commit 4c96475 into xorbitsai:main Nov 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.16
3 participants
@codingl2k1 @qinxuye @XprobeBot