refactor(core)!: remove workspace.locator
#5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
workspace.locatoris quite useless and only creates confusion withworkspace.anchoredLocator.At the moment, it's only used in places that need an ident, which
workspace.anchoredLocatorcan happily provide.In the past, it was also used accidentally instead of
workspace.anchoredLocatorbefore I fixed it in #4937.How did you fix it?
Removed it since it doesn't provide any benefits. Its only actual use is comparisons in
project.tryWorkspaceByLocator, but nobody has ever passed it toproject.tryWorkspaceByLocatoranyways.Checklist