Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(omnichannel): stop calling an object through proxy #33719

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 23, 2024

ARCH-1307
backport from #33596

running microservices very often you will find cannot call shouldStart from undefined or something pretty close.

the reason is because we are calling getQueueWorker from a proxy and the return undefined.

dont ask me why its working fine on CI, but locally it fails 100% local

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 45c7c44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/network-broker Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (b59bedc) to head (45c7c44).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33719   +/-   ##
========================================
  Coverage    75.01%   75.01%           
========================================
  Files          480      480           
  Lines        21000    21000           
  Branches      5329     5329           
========================================
  Hits         15754    15754           
  Misses        4619     4619           
  Partials       627      627           
Flag Coverage Δ
unit 75.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33719/
on branch gh-pages at 2024-10-23 14:07 UTC

@ggazzo ggazzo changed the title fix: stop calling an object through proxy fix(omnichannel): stop calling an object through proxy Oct 23, 2024
@ggazzo ggazzo added this to the 7.0 milestone Oct 23, 2024
@ggazzo ggazzo marked this pull request as ready for review October 23, 2024 16:43
@ggazzo ggazzo requested review from a team as code owners October 23, 2024 16:43
KevLehman
KevLehman previously approved these changes Oct 23, 2024
@ggazzo ggazzo merged commit 63ccadc into develop Oct 23, 2024
43 of 44 checks passed
@ggazzo ggazzo deleted the fix/queue-omni-should-start branch October 23, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants