fix: Omnichannel queue starting multiple times due to race condition

[aleksandernsilva]

Proposed changes (including videos or screenshots)

This PR fixes a bug causing the Omnichannel queue to start more than once due to a race condition. In order to prevent the race condition settings.watch was changed to settings.watchMultiple which has a debounce built in.

Bug caught through this test omnichannel-livechat-queue-management-autoselection.spec.ts

Introduced here: #33719

Issue(s)

Steps to test or reproduce

Further comments

CONN-429

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 5be0a84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34062/
on branch gh-pages at 2024-11-29 21:36 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (18cea50) to head (5be0a84).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #34062      +/-   ##
===========================================
+ Coverage    75.75%   75.79%   +0.03%     
===========================================
  Files          510      511       +1     
  Lines        22078    22130      +52     
  Branches      5387     5394       +7     
===========================================
+ Hits         16726    16773      +47     
- Misses        4706     4709       +3     
- Partials       646      648       +2     

Flag	Coverage Δ
unit	75.79% <90.56%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[pierre-lehnen-rc]

It will still be called multiple times as shouldStart is also called when the license is validated.