feat(rust): derive Copy on some public enums #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasantosr
commented
Mar 24, 2024
| @@ -386,7 +386,7 @@ impl PartitionWriter { | |||
| self.flush_arrow_writer().await?; | |||
| } | |||
| } | |||
| self.arrow_writer.flush(); | |||
| self.arrow_writer.flush()?; | |||
There was a problem hiding this comment.
I've also included this non-related change, because the arrow result was not being used, but it should.
ion-elgreco
reviewed
Mar 29, 2024
| @@ -997,7 +997,7 @@ async fn execute( | |||
|
|
|||
| let source_schema = source.schema(); | |||
| let target_schema = target.schema(); | |||
| let join_schema_df = build_join_schema(source_schema, &target_schema, &JoinType::Full)?; | |||
| let join_schema_df = build_join_schema(source_schema, target_schema, &JoinType::Full)?; | |||
There was a problem hiding this comment.
Why is this not a reference anymore?
There was a problem hiding this comment.
That's a clippy warning, because target.schema() already returns a reference, so that double reference was being automatically dereferenced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR derives the
Copytrait on public enums that had theClonetrait derived, when applicable.