feat(rust): derive Copy on some public enums

crates/core/src/kernel/expressions/mod.rs

@@ -95,7 +95,7 @@ impl ExpressionEvaluator for DefaultExpressionEvaluator {
     }
 }
 
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+#[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)]
 /// A binary operator.
 pub enum BinaryOperator {
     /// Arithmetic Plus
@@ -121,7 +121,7 @@ pub enum BinaryOperator {
 }
 
 /// Variadic operators
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Copy, Clone, PartialEq)]
 pub enum VariadicOperator {
     /// AND
     And,
@@ -148,7 +148,7 @@ impl Display for BinaryOperator {
     }
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Copy, Clone, PartialEq)]
 /// A unary operator.
 pub enum UnaryOperator {
     /// Unary Not

crates/core/src/kernel/expressions/scalars.rs

@@ -395,7 +395,7 @@ impl From<String> for Scalar {
 
 impl PrimitiveType {
     fn data_type(&self) -> DataType {
-        DataType::Primitive(self.clone())
+        DataType::Primitive(*self)
     }
 
     /// Parses a string into a scalar value.

crates/core/src/kernel/models/actions.rs

@@ -353,7 +353,7 @@ impl From<&parquet::record::Field> for WriterFeatures {
 }
 
 ///Storage type of deletion vector
-#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Serialize, Deserialize, Copy, Clone, Debug, PartialEq, Eq)]
 pub enum StorageType {
     /// Stored at relative path derived from a UUID.
     #[serde(rename = "u")]
@@ -768,7 +768,7 @@ pub struct Sidecar {
     pub tags: Option<HashMap<String, Option<String>>>,
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq)]
+#[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq, Eq)]
 /// The isolation level applied during transaction
 pub enum IsolationLevel {
     /// The strongest isolation level. It ensures that committed write operations

crates/core/src/kernel/models/schema.rs

@@ -474,7 +474,7 @@ pub const DECIMAL_MAX_PRECISION: u8 = 38;
 /// The maximum scale for [PrimitiveType::Decimal] values
 pub const DECIMAL_MAX_SCALE: i8 = 38;
 
-#[derive(Debug, Serialize, Deserialize, PartialEq, Clone, Eq, Hash)]
+#[derive(Debug, Serialize, Deserialize, PartialEq, Copy, Clone, Eq, Hash)]
 #[serde(rename_all = "snake_case")]
 /// Primitive types supported by Delta
 pub enum PrimitiveType {

crates/core/src/operations/create.rs

@@ -303,7 +303,7 @@ impl CreateBuilder {
         }
 
         let operation = DeltaOperation::Create {
-            mode: self.mode.clone(),
+            mode: self.mode,
             metadata: metadata.clone(),
             location: storage_url,
             protocol: protocol.clone(),
@@ -327,7 +327,7 @@ impl std::future::IntoFuture for CreateBuilder {
     fn into_future(self) -> Self::IntoFuture {
         let this = self;
         Box::pin(async move {
-            let mode = this.mode.clone();
+            let mode = this.mode;
             let app_metadata = this.metadata.clone().unwrap_or_default();
             let (mut table, actions, operation) = this.into_table_and_actions()?;
             let log_store = table.log_store();

crates/core/src/operations/merge/mod.rs

@@ -997,7 +997,7 @@ async fn execute(
 
     let source_schema = source.schema();
     let target_schema = target.schema();
-    let join_schema_df = build_join_schema(source_schema, &target_schema, &JoinType::Full)?;
+    let join_schema_df = build_join_schema(source_schema, target_schema, &JoinType::Full)?;
     let predicate = match predicate {
         Expression::DataFusion(expr) => expr,
         Expression::String(s) => parse_predicate_expression(&join_schema_df, s, &state)?,

crates/core/src/operations/transaction/mod.rs

@@ -513,7 +513,7 @@ impl<'a> std::future::IntoFuture for PreparedCommit<'a> {
                             Err(err) => {
                                 this.log_store
                                     .object_store()
-                                    .delete_with_retries(&tmp_commit, 15)
+                                    .delete_with_retries(tmp_commit, 15)
                                     .await?;
                                 return Err(TransactionError::CommitConflict(err).into());
                             }
@@ -522,7 +522,7 @@ impl<'a> std::future::IntoFuture for PreparedCommit<'a> {
                     Err(err) => {
                         this.log_store
                             .object_store()
-                            .delete_with_retries(&tmp_commit, 15)
+                            .delete_with_retries(tmp_commit, 15)
                             .await?;
                         return Err(err.into());
                     }

crates/core/src/operations/writer.rs

@@ -386,7 +386,7 @@ impl PartitionWriter {
                 self.flush_arrow_writer().await?;
             }
         }
-        self.arrow_writer.flush();
+        self.arrow_writer.flush()?;
         Ok(())
     }
 

crates/core/src/protocol/mod.rs

@@ -552,7 +552,7 @@ impl DeltaOperation {
 }
 
 /// The SaveMode used when performing a DeltaOperation
-#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq)]
+#[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq, Eq)]
 pub enum SaveMode {
     /// Files will be appended to the target location.
     Append,
@@ -582,7 +582,7 @@ impl FromStr for SaveMode {
 }
 
 /// The OutputMode used in streaming operations.
-#[derive(Serialize, Deserialize, Debug, Clone)]
+#[derive(Serialize, Deserialize, Debug, Copy, Clone)]
 pub enum OutputMode {
     /// Only new rows will be written when new data is available.
     Append,

crates/core/src/table/builder.rs

@@ -39,7 +39,7 @@ impl From<BuilderError> for DeltaTableError {
 }
 
 /// possible version specifications for loading a delta table
-#[derive(Debug, Clone, PartialEq, Eq, Default)]
+#[derive(Debug, Copy, Clone, PartialEq, Eq, Default)]
 pub enum DeltaVersion {
     /// load the newest version
     #[default]
@@ -321,7 +321,7 @@ impl DeltaTableBuilder {
 
     /// Build the [`DeltaTable`] and load its state
     pub async fn load(self) -> DeltaResult<DeltaTable> {
-        let version = self.options.version.clone();
+        let version = self.options.version;
         let mut table = self.build()?;
         match version {
             DeltaVersion::Newest => table.load().await?,

crates/core/src/table/config.rs

@@ -362,7 +362,7 @@ impl<'a> TableConfig<'a> {
     }
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]
+#[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)]
 /// The isolation level applied during transaction
 pub enum IsolationLevel {
     /// The strongest isolation level. It ensures that committed write operations
@@ -460,7 +460,7 @@ impl FromStr for CheckpointPolicy {
     }
 }
 
-#[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]
+#[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)]
 /// The Column Mapping modes used for reading and writing data
 #[serde(rename_all = "camelCase")]
 pub enum ColumnMappingMode {

crates/core/src/table/state_arrow.rs

@@ -328,7 +328,7 @@ impl DeltaTableState {
 
         for add in files {
             if let Some(value) = &add.deletion_vector {
-                storage_type.append_value(&value.storage_type);
+                storage_type.append_value(value.storage_type);
                 path_or_inline_div.append_value(value.path_or_inline_dv.clone());
                 if let Some(ofs) = value.offset {
                     offset.append_value(ofs);

crates/core/src/writer/mod.rs

@@ -125,7 +125,7 @@ impl From<DeltaWriterError> for DeltaTableError {
 }
 
 /// Write mode for the [DeltaWriter]
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Copy, Clone, Debug, PartialEq)]
 pub enum WriteMode {
     /// Default write mode which will return an error if schemas do not match correctly
     Default,

crates/core/src/writer/record_batch.rs

@@ -198,7 +198,7 @@ impl DeltaWriter<RecordBatch> for RecordBatchWriter {
 
         for result in self.divide_by_partition_values(&values)? {
             let schema = self
-                .write_partition(result.record_batch, &result.partition_values, mode.clone())
+                .write_partition(result.record_batch, &result.partition_values, mode)
                 .await?;
             self.arrow_schema_ref = schema;
         }

crates/sql/src/parser.rs

@@ -14,7 +14,7 @@ macro_rules! parser_err {
     };
 }
 
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Copy, Clone, PartialEq, Eq)]
 pub enum DescribeOperation {
     Detail,
     History,

python/src/schema.rs

@@ -145,7 +145,7 @@ impl PrimitiveType {
 
     #[pyo3(text_signature = "($self)")]
     fn to_json(&self) -> PyResult<String> {
-        let inner_type = DataType::Primitive(self.inner_type.clone());
+        let inner_type = DataType::Primitive(self.inner_type);
         serde_json::to_string(&inner_type).map_err(|err| PyException::new_err(err.to_string()))
     }
 
@@ -160,7 +160,7 @@ impl PrimitiveType {
 
     #[pyo3(text_signature = "($self)")]
     fn to_pyarrow(&self) -> PyResult<PyArrowType<ArrowDataType>> {
-        let inner_type = DataType::Primitive(self.inner_type.clone());
+        let inner_type = DataType::Primitive(self.inner_type);
         Ok(PyArrowType((&inner_type).try_into().map_err(
             |err: ArrowError| PyException::new_err(err.to_string()),
         )?))