Skip to content

Commit

Permalink
Merge pull request #2126 from github/charisk/cli-v2.12.3-hack
Browse files Browse the repository at this point in the history
Hack to avoid CodeQL CLI v2.12.3
  • Loading branch information
aeisenberg authored Mar 1, 2023
2 parents 56d283f + e9787c2 commit ea9dede
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions extensions/ql-vscode/src/distribution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,15 @@ class ExtensionSpecificDistributionManager {
const extensionSpecificRelease = this.getInstalledRelease();
const latestRelease = await this.getLatestRelease();

// v2.12.3 was released with a bug that causes the extension to fail
// so we force the extension to ignore it.
if (
extensionSpecificRelease &&
extensionSpecificRelease.name === "v2.12.3"
) {
return createUpdateAvailableResult(latestRelease);
}

if (
extensionSpecificRelease !== undefined &&
codeQlPath !== undefined &&
Expand Down Expand Up @@ -430,6 +439,12 @@ class ExtensionSpecificDistributionManager {
this.versionRange,
this.config.includePrerelease,
(release) => {
// v2.12.3 was released with a bug that causes the extension to fail
// so we force the extension to ignore it.
if (release.name === "v2.12.3") {
return false;
}

const matchingAssets = release.assets.filter(
(asset) => asset.name === requiredAssetName,
);
Expand Down

0 comments on commit ea9dede

Please sign in to comment.