-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack to avoid CodeQL CLI v2.12.3 #2126
Conversation
extensionSpecificRelease && | ||
extensionSpecificRelease.name === "v2.12.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
extensionSpecificRelease && | |
extensionSpecificRelease.name === "v2.12.3" | |
extensionSpecificRelease?.name === "v2.12.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like at this point, we are guaranteed that 2.12.2 was not chosen since it is already being filtered out in this.getLatestRelease()
. Is that true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extensionSpecificRelease
is installed version though I think. So basically this is for the scenario where the user is already on v2.12.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean 2.12.2
or 2.12.3
?
I agree it should be the case that latestRelease
cannot be 2.12.3
since it should be considered incompatible and get filtered out. Even if you're already on 2.12.3
it'll report 2.12.2
as the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean 2.12.2 or 2.12.3?
Yes. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the manual testing.
We are instead going to revert the relevant PRs and release from main. |
(Paired with @robertbrignull)
CodeQL CLI v2.12.3 was released with a bug that causes the extension to fail so we force the extension to ignore it.
Raising the PR against main for now, but we might need to target a different branch.
The CHANGELOG will need to be updated.
Checklist
ready-for-doc-review
label there.