Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new telemetry by default #2114

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Enable new telemetry by default #2114

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4127be2
Enable new telemetry by default
robertbrignull Feb 27, 2023
c37096b
Update changelog
robertbrignull Feb 27, 2023
b1ddf89
Update CHANGELOG.md
robertbrignull Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/ql-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## [UNRELEASED]

## [UNRELEASED]
- Enable collection of telemetry for UI interactions in webviews. [#2114](https://github.com/github/vscode-codeql/pull/2114)
charisk marked this conversation as resolved.
Show resolved Hide resolved

# 1.7.10 - 23 February 2023

Expand Down
7 changes: 1 addition & 6 deletions extensions/ql-vscode/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,8 @@ export const GLOBAL_ENABLE_TELEMETRY = new Setting(
GLOBAL_TELEMETRY_SETTING,
);

const ENABLE_NEW_TELEMETRY = new Setting(
"enableNewTelemetry",
TELEMETRY_SETTING,
);

export function newTelemetryEnabled(): boolean {
return ENABLE_NEW_TELEMETRY.getValue<boolean>();
return true;
}

// Distribution configuration
Expand Down
4 changes: 4 additions & 0 deletions extensions/ql-vscode/test/vscode-tests/no-workspace/telemetry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,10 @@ describe("telemetry reporting", () => {
});

describe("when new telementry is not enabled", () => {
beforeEach(async () => {
jest.spyOn(Config, "newTelemetryEnabled").mockReturnValue(false);
});

it("should not send a ui-interaction telementry event", async () => {
await telemetryListener.initialize();

Expand Down