Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new telemetry by default #2114

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented Feb 27, 2023

Enables the new telemetry events. Previous this was opt-in on top of the existing telemetry, but now it'll be included for anyone that is opted in to existing telemetry.

This new telemetry currently only includes clicking on UI elements in web views, such as buttons and links. See https://codeql.github.com/docs/codeql-for-visual-studio-code/about-telemetry-in-codeql-for-visual-studio-code/ for the full information on what telemetry we collect.

Also see #2115 for cleaning up afterwards, but I'll avoid merging that PR until after the next release to reduce code churn and make reverting easier.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team February 27, 2023 13:11
@robertbrignull robertbrignull requested a review from a team as a code owner February 27, 2023 13:11
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

extensions/ql-vscode/CHANGELOG.md Outdated Show resolved Hide resolved
@robertbrignull robertbrignull merged commit 56e8d8a into main Feb 27, 2023
@robertbrignull robertbrignull deleted the robertbrignull/enable_telemetry branch February 27, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants