Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup config to enabling new telemetry #2115

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Cleanup config to enabling new telemetry #2115

merged 1 commit into from
Mar 3, 2023

Conversation

robertbrignull
Copy link
Contributor

Follows on from #2114 and cleans up the config and places where we checked if the new telemetry collection was enabled.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team February 27, 2023 13:13
@robertbrignull robertbrignull requested a review from a team as a code owner February 27, 2023 13:13
@robertbrignull robertbrignull marked this pull request as draft February 27, 2023 13:13
@robertbrignull robertbrignull mentioned this pull request Feb 27, 2023
Merged
3 tasks
Base automatically changed from robertbrignull/enable_telemetry to main February 27, 2023 16:46
norascheuch
norascheuch approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@robertbrignull robertbrignull force-pushed the robertbrignull/cleanup_new_telemetry branch from 7662870 to 082a00e Compare March 3, 2023 11:55
@robertbrignull robertbrignull marked this pull request as ready for review March 3, 2023 11:55
@robertbrignull
Copy link
Contributor Author

Collection of new telemetry events has been released now. We're receiving data and haven't heard any reports of problems. So I think we should be good to merge this cleanup PR now.

charisk
charisk approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@robertbrignull robertbrignull merged commit 53492b5 into main Mar 3, 2023
@robertbrignull robertbrignull deleted the robertbrignull/cleanup_new_telemetry branch March 3, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norascheuch norascheuch norascheuch approved these changes

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
secexp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbrignull @charisk @norascheuch